Return-Path: Sender: "Gustavo F. Padovan" Date: Wed, 1 Dec 2010 15:49:10 -0200 From: "Gustavo F. Padovan" To: Stefan Seyfried Cc: Marcel Holtmann , linux-bluetooth@vger.kernel.org, gregkh@suse.de, Stefan Seyfried , Oliver Neukum Subject: Re: [PATCH] btusb: Fix log spamming due to autosuspend Message-ID: <20101201174910.GA16125@vigoh> References: <1291150148-14376-1-git-send-email-stefan.seyfried@googlemail.com> <1291200140.4795.91.camel@aeonflux> <20101201154714.517289f7@susi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20101201154714.517289f7@susi> List-ID: Hi Stefan, * Stefan Seyfried [2010-12-01 15:47:14 +0100]: > Hi Marcel, > > On Wed, 01 Dec 2010 11:42:20 +0100 > Marcel Holtmann wrote: > > > Hi Stefan, > > > > > If a device is autosuspended an inability to resubmit URBs is > > > to be expected. Check the error code and only log real errors. > > > (Now that autosuspend is default enabled for btusb, those log > > > messages were happening all the time e.g. with a BT mouse) > > > > > > Signed-off-by: Stefan Seyfried > > > Signed-off-by: Oliver Neukum > > > > we had a similar one some time ago, but I am fine with this one as well. > > Actually this one might be a bit better since it still keeps some > > errors. > > > > Acked-by: Marcel Holtmann > > Could you (or Gustavo) send it to Linus? It's pretty trivial, but the > messages are annoying and users will complain if they are still in 2.6.37 > final. I'll send it, applied to bluetooth-2.6 tree. Thanks. -- Gustavo F. Padovan http://profusion.mobi