Return-Path: <cyrus@holtmann.org>
Subject: Re: [PATCH] [RFC] HDP: reject MDL reconnection with different MTU
Mime-Version: 1.0 (Apple Message framework v1082)
Content-Type: text/plain; charset=iso-8859-1
From: =?iso-8859-1?Q?Elvis_Pf=FCtzenreuter?= <epx@signove.com>
In-Reply-To: <AANLkTikjeQ1Yemc8w1hqemk6NUdGmUr5sSBg1e9KZQR6@mail.gmail.com>
Date: Fri, 14 Jan 2011 09:27:46 -0200
Cc: linux-bluetooth@vger.kernel.org
Message-Id: <B163F641-CA75-4C1D-9C65-B5F6C4C6D463@signove.com>
References: <1294960264-7622-1-git-send-email-epx@signove.com> <33e10449eddb45a9d7de33c23d05e14f@libresoft.es> <AANLkTi=3QDhRvEn74radQJXWnN8Sn3KUDDBTHQk6A-Zw@mail.gmail.com> <AANLkTikjeQ1Yemc8w1hqemk6NUdGmUr5sSBg1e9KZQR6@mail.gmail.com>
To: Jose Antonio Santos Cadenas <jcaden@libresoft.es>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>


On 14 Jan 2011, at 09:15 , Jose Antonio Santos Cadenas wrote:

> 2011/1/14 Jose Antonio Santos Cadenas <jcaden@libresoft.es>:
>> 2011/1/14 Jos? Antonio Santos Cadenas <jcaden@libresoft.es>
>>> 
>>> Hi Elvis,
>>> 
>>> On Thu, 13 Jan 2011 21:11:04 -0200, Elvis Pfützenreuter wrote:
>>>> 
>>>> From: Elvis Pfutzenreuter <epx@signove.com>
>>>> 
>>>> This patch implements refusal of a MDL reconnection if the new L2CAP
>>>> connection presents a different MTU. Accordingly to HDP spec. item 3.5.
>>>> 
>>>> It aims to pass the TC_SNK_HCT_BV_07_C PTS test. (It does not pass yet
>>>> because PTS itself seems to have issues. See ticket 7121 for details.)
>> 
> 
> I finish the tests I'd like to do. Just I'm concerned about why you
> are using just OMTU value instead of both values IMTU and OMTU. Will
> not be better to store and check both of them?

Indeed. I will fix this and submit another round.