Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1292584829-28279-1-git-send-email-par-gunnar.p.hjalmdahl@stericsson.com> <201101061946.04790.arnd@arndb.de> <201101091955.05174.arnd@arndb.de> Date: Fri, 25 Feb 2011 18:55:03 +0100 Message-ID: Subject: Re: [PATCH 00/11] mfd and bluetooth: Add CG2900 suppor From: Vitaly Wool To: Linus Walleij Cc: Par-Gunnar HJALMDAHL , Samuel Ortiz , Marcel Holtmann , Lee Jones , Par-Gunnar Hjalmdahl , Alan Cox , Arnd Bergmann , "linux-bluetooth@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Lukasz Rymanowski , Pavan Savoy Content-Type: multipart/alternative; boundary=bcaec53f8f0d950b6e049d1f0773 List-ID: --bcaec53f8f0d950b6e049d1f0773 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, Sorry to say, but I have to disagree. This patchset represents overcomplicated and unclear model, which may be misleading for developers implementing similar solution for another platform. Making hardware work is, if course, a valid point, but porting a windows driver would do that as well, and it's not the reason to pull windows drivers' ports into mainline. Thanks, Vitaly Den 25 feb 2011 18:08 skrev "Linus Walleij" : > 2011/2/24 Par-Gunnar HJALMDAHL : > >> I sent the mail below one month ago, but have still not received any answers or further comments. >> Has anyone of you who made comments on the CG2900 patches earlier, any more comments or questions? > > I think I have provided > Acked-by: Linus Walleij > (or the earlier ST-Ericsson address, which is equal) for these patches. > Else I do so now. > > FWIW: I think those who want another architectural solution > can propose a refactoring patch any day they like, and if it's > recieved like "ah, that's better" ACK from P=E4r-Gunnar et al, then > it's no big deal. > > This makes the hardware work with 2.6.39 which is really most > important IMO, Sam can you merge this as it stands? > > Yours, > Linus Walleij --bcaec53f8f0d950b6e049d1f0773 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

Hi,

Sorry to say, but I have to disagree. This patchset represents overcompl= icated and unclear model, which may be misleading for developers implementi= ng similar solution for another platform.

Making hardware work is, if course, a valid point, but porting a windows= driver would do that as well, and it's not the reason to pull windows = drivers' ports into mainline.

Thanks,
=A0=A0 Vitaly

Den 25 feb 2011 18:08 skrev "Linus Walleij&= quot; <linus.walleij@linaro.= org>:
> 2011/2/24 Par-Gunnar HJALMDAHL &l= t;par-gunnar.p.hja= lmdahl@stericsson.com>:
>
>> I sent the mail below one month ago, but have still not r= eceived any answers or further comments.
>> Has anyone of you who = made comments on the CG2900 patches earlier, any more comments or questions= ?
>
> I think I have provided
> Acked-by: Linus Walleij <<= a href=3D"mailto:linus.walleij@linaro.org">linus.walleij@linaro.org>=
> (or the earlier ST-Ericsson address, which is equal) for these pat= ches.
> Else I do so now.
>
> FWIW: I think those who want anothe= r architectural solution
> can propose a refactoring patch any day th= ey like, and if it's
> recieved like "ah, that's better&= quot; ACK from P=E4r-Gunnar et al, then
> it's no big deal.
>
> This makes the hardware work wi= th 2.6.39 which is really most
> important IMO, Sam can you merge thi= s as it stands?
>
> Yours,
> Linus Walleij
--bcaec53f8f0d950b6e049d1f0773--