Return-Path: <cyrus@holtmann.org>
MIME-Version: 1.0
In-Reply-To: <AANLkTinNDU3ywqVLNfNn8iGcgM3+8k+Rmicnc85SvKqk@mail.gmail.com>
References: <1299270913-8436-1-git-send-email-andre.guedes@openbossa.org>
	<1299270913-8436-2-git-send-email-andre.guedes@openbossa.org>
	<AANLkTinNDU3ywqVLNfNn8iGcgM3+8k+Rmicnc85SvKqk@mail.gmail.com>
Date: Thu, 10 Mar 2011 18:56:50 -0300
Message-ID: <AANLkTimtFwnf2nJdgY76iKuVWmRVhNpMUGnv4yD8oMmk@mail.gmail.com>
Subject: Re: [RFC 1/6] Bluetooth: Implement advertising report meta event
From: Andre Guedes <andre.guedes@openbossa.org>
To: Anderson Briglia <anderson.briglia@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Ok,

Please, do not consider this patch set, I will rebase and send a v2 soon.

Thanks,

Andre.

On Wed, Mar 9, 2011 at 10:58 AM, Anderson Briglia
<anderson.briglia@openbossa.org> wrote:
>
> Hi,
>
> On Fri, Mar 4, 2011 at 4:35 PM, Andre Guedes <andre.guedes@openbossa.org> wrote:
> > From: Anderson Briglia <anderson.briglia@openbossa.org>
> >
> > This patch implements new LE meta event in order to handle advertising
> > reports.
> >
> > Signed-off-by: Anderson Briglia <anderson.briglia@openbossa.org>
> > ---
> > ?include/net/bluetooth/hci.h | ? 18 ++++++++++++++++++
> > ?net/bluetooth/hci_event.c ? | ? 22 ++++++++++++++++++++++
> > ?2 files changed, 40 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> > index d851f8b..fdcc494 100644
> > --- a/include/net/bluetooth/hci.h
> > +++ b/include/net/bluetooth/hci.h
> > @@ -1011,6 +1011,24 @@ struct hci_ev_le_conn_complete {
> > ? ? ? ?__u8 ? ? clk_accurancy;
> > ?} __packed;
> >
> > +#define ADV_IND ? ? ? ? ? ? ? ?0x00
> > +#define ADV_DIRECT_IND 0x01
> > +#define ADV_SCAN_IND ? 0x02
> > +#define ADV_NONCONN_IND ? ? ? ?0x03
> > +#define SCAN_RSP ? ? ? 0x04
> > +
> > +#define ADDR_DEV_PUBLIC ? ? ? ?0x00
> > +#define ADDR_DEV_RANDOM ? ? ? ?0x01
> > +
> > +#define HCI_EV_LE_ADVERTISING_REPORT ? 0x02
> > +struct hci_ev_le_advertising_info {
> > + ? ? ? __u8 ? ? evt_type;
> > + ? ? ? __u8 ? ? bdaddr_type;
> > + ? ? ? bdaddr_t bdaddr;
> > + ? ? ? __u8 ? ? length;
> > + ? ? ? __u8 ? ? data[0];
> > +} __packed;
> > +
> > ?#define HCI_EV_LE_LTK_REQ ? ? ? ? ? ? ?0x05
> > ?struct hci_ev_le_ltk_req {
> > ? ? ? ?__le16 ?handle;
> > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> > index 5a2ab2c..8acc4a5 100644
> > --- a/net/bluetooth/hci_event.c
> > +++ b/net/bluetooth/hci_event.c
> > @@ -2556,6 +2556,24 @@ static inline void hci_le_ltk_request_evt(struct hci_dev *hdev,
> > ? ? ? ?hci_dev_unlock(hdev);
> > ?}
> >
> > +static inline void hci_le_adv_report_evt(struct hci_dev *hdev,
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct sk_buff *skb)
> > +{
> > + ? ? ? struct hci_ev_le_advertising_info *ev;
> > + ? ? ? u8 num_reports, i;
> > +
> > + ? ? ? num_reports = skb->data[0];
> > +
> > + ? ? ? ev = (void *) &skb->data[1];
> > +
> > + ? ? ? BT_DBG("adv from: %s", batostr(&ev->bdaddr));
> > +
> > + ? ? ? for (i = 1; i < num_reports; i++) {
> > + ? ? ? ? ? ? ? ev = (void *) (ev->data + ev->length + 1);
> > + ? ? ? ? ? ? ? BT_DBG("adv from: %s", batostr(&ev->bdaddr));
> > + ? ? ? }
> > +}
> > +
> > ?static inline void hci_le_meta_evt(struct hci_dev *hdev, struct sk_buff *skb)
> > ?{
> > ? ? ? ?struct hci_ev_le_meta *le_ev = (void *) skb->data;
> > @@ -2571,6 +2589,10 @@ static inline void hci_le_meta_evt(struct hci_dev *hdev, struct sk_buff *skb)
> > ? ? ? ? ? ? ? ?hci_le_ltk_request_evt(hdev, skb);
> > ? ? ? ? ? ? ? ?break;
> >
> > + ? ? ? case HCI_EV_LE_ADVERTISING_REPORT:
> > + ? ? ? ? ? ? ? hci_le_adv_report_evt(hdev, skb);
> > + ? ? ? ? ? ? ? break;
> > +
> > ? ? ? ?default:
> > ? ? ? ? ? ? ? ?break;
> > ? ? ? ?}
> > --
> > 1.7.1
> >
> >
>
> Please, do not consider this patch. I have another one with some
> modifications proposed by padovan. Andre, rebase your git tree,
> please.
>
>
> --
> INdT - Instituto Nokia de tecnologia
> +55 2126 1122
> http://techblog.briglia.net