Return-Path: Date: Fri, 4 Mar 2011 23:12:57 -0300 From: "Gustavo F. Padovan" To: David Fries Cc: Liang Bao , Andrei Warkentin , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Feng Tang Subject: Re: [PATCH] work around for l2cap NULL dereference in l2cap_conn_start Message-ID: <20110305021257.GD9005@joana> References: <20110211035309.GA22204@spacedout.fries.net> <20110214145649.GE2597@joana> <20110221043601.GB22204@spacedout.fries.net> <20110227191545.GB2166@joana> <20110228050340.GC22204@spacedout.fries.net> <20110228173022.GC2165@joana> <20110302061910.GE22204@spacedout.fries.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110302061910.GE22204@spacedout.fries.net> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi David, * David Fries [2011-03-02 00:19:10 -0600]: > On Mon, Feb 28, 2011 at 02:30:22PM -0300, Gustavo F. Padovan wrote: > > Hi David, > > > > * David Fries [2011-02-27 23:03:40 -0600]: > > > > > On Sun, Feb 27, 2011 at 04:15:45PM -0300, Gustavo F. Padovan wrote: > > > > I pushed the following patch to bluetooth-2.6 tree. It should fix the problem > > > > by avoiding connections to be accepted before a L2CAP info response comes: > > > > > > Is > > > git://git.kernel.org/pub/scm/linux/kernel/git/padovan/bluetooth-2.6.git > > > the bluetooth-2.6 tree you mentioned? I don't see your patch there. > > > As a side note, the inline patch in your e-mail has the tabs replaced by > > > spaces, once I changed them, it applied cleanly. > > > > > > I first reverted to the base N900 kernel-power-2.6.28 46 (none of my > > > changes or debugging), it crashed as expected. I then applied your > > > patch 743400e0, and it still crashed. I added back the > > > l2cap_conn_start parent check and some debugging in af_bluetooth.c > > > dmesg debug output and patches follow. > > > > I want to see a test with this patch and a recent kernel. We added many fixes > > to stack in the last two years. Can you test this scenario? > > I'm sorry, but apparently not, at least this post says 2.6.37 isn't > going to happen for the N900 and Maemo. > http://forums.internettablettalk.com/showthread.php?t=70082 > > I tried 2.6.37-n900 from > git://gitorious.org/nokia-n900-kernel/nokia-n900-kernel.git anyway, > but the display visibly degrades like it isn't being updated and > doesn't apparently get any further. I don't have anyway to debug it > further. I think you can test this in a desktop machine. -- Gustavo F. Padovan http://profusion.mobi