Return-Path: MIME-Version: 1.0 In-Reply-To: <20110524104223.GD2480@null> References: <1305936645-15007-1-git-send-email-andre.guedes@openbossa.org> <1305936645-15007-4-git-send-email-andre.guedes@openbossa.org> <20110524104223.GD2480@null> Date: Wed, 25 May 2011 13:42:42 -0300 Message-ID: Subject: Re: [PATCH v2 04/11] Bluetooth: LE Set Scan Enable command complete event From: Andre Guedes To: Ville Tervo Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Padovan, Please, don't consider this v2 patchset. I will consider Ville's comments and send a new version soon. Thanks Ville. - Andre On Tue, May 24, 2011 at 7:42 AM, Ville Tervo wrote: > Hi Andre, > > On Fri, May 20, 2011 at 09:10:38PM -0300, ext Andre Guedes wrote: >> This patch adds a function handler to the command complete event >> generated by the LE Set Scan Enable command. >> > > This patch is not doing anything besides DBG(). Drop it and introduce again > when it is really needed. hcidump gives same information. > >> Signed-off-by: Andre Guedes >> --- >> ?include/net/bluetooth/hci.h | ? ?2 ++ >> ?net/bluetooth/hci_event.c ? | ? 12 ++++++++++++ >> ?2 files changed, 14 insertions(+), 0 deletions(-) >> >> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h >> index ec0fb2d..bc90da9 100644 >> --- a/include/net/bluetooth/hci.h >> +++ b/include/net/bluetooth/hci.h >> @@ -710,6 +710,8 @@ struct hci_rp_le_read_buffer_size { >> ? ? ? __u8 ? ? le_max_pkt; >> ?} __packed; >> >> +#define HCI_OP_LE_SET_SCAN_ENABLE ? ?0x200c >> + >> ?#define HCI_OP_LE_CREATE_CONN ? ? ? ? ? ? ? ?0x200d >> ?struct hci_cp_le_create_conn { >> ? ? ? __le16 ? scan_interval; >> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c >> index 458caac..ccf4d4d 100644 >> --- a/net/bluetooth/hci_event.c >> +++ b/net/bluetooth/hci_event.c >> @@ -839,6 +839,14 @@ static void hci_cc_read_local_oob_data_reply(struct hci_dev *hdev, >> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? rp->randomizer, rp->status); >> ?} >> >> +static void hci_cc_le_set_scan_enable(struct hci_dev *hdev, >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct sk_buff *skb) >> +{ >> + ? ? __u8 status = *((__u8 *) skb->data); >> + >> + ? ? BT_DBG("%s status 0x%x", hdev->name, status); >> +} >> + >> ?static inline void hci_cs_inquiry(struct hci_dev *hdev, __u8 status) >> ?{ >> ? ? ? BT_DBG("%s status 0x%x", hdev->name, status); >> @@ -1814,6 +1822,10 @@ static inline void hci_cmd_complete_evt(struct hci_dev *hdev, struct sk_buff *sk >> ? ? ? ? ? ? ? hci_cc_user_confirm_neg_reply(hdev, skb); >> ? ? ? ? ? ? ? break; >> >> + ? ? case HCI_OP_LE_SET_SCAN_ENABLE: >> + ? ? ? ? ? ? hci_cc_le_set_scan_enable(hdev, skb); >> + ? ? ? ? ? ? break; >> + >> ? ? ? default: >> ? ? ? ? ? ? ? BT_DBG("%s opcode 0x%x", hdev->name, opcode); >> ? ? ? ? ? ? ? break; >> -- >> 1.7.4.1 > > -- > Ville >