Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1306199164-28310-1-git-send-email-jaikumar@google.com> <20110524083723.GB2480@null> From: Jaikumar Ganesh Date: Tue, 24 May 2011 09:44:05 -0700 Message-ID: Subject: Re: [PATCH] Bluetooth: Add BT_POWER L2CAP socket option. To: Luiz Augusto von Dentz Cc: Ville Tervo , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Luiz, Ville: On Tue, May 24, 2011 at 9:20 AM, Luiz Augusto von Dentz wrote: > > Hi Jaikumar, > > On Tue, May 24, 2011 at 11:37 AM, Ville Tervo wrote: > > Hi Jaikumar, > > > > On Mon, May 23, 2011 at 06:06:04PM -0700, ext Jaikumar Ganesh wrote: > >> Add BT_POWER socket option used to control the power > >> characteristics of the underlying ACL link. When the remote end > >> has put the link in sniff mode and the host stack wants to send > >> data we need need to explicitly exit sniff mode to work well with > >> certain devices (For example, A2DP on Plantronics Voyager 855). > >> However, this causes problems with HID devices. > >> > >> Hence, moving into active mode when sending data, irrespective > >> of who set the sniff mode has been made as a socket option. By > >> default, we will move into active mode. HID devices can set the > >> L2CAP socket option to prevent this from happening. > >> > > > > I would prefer keeping old way the default way. Otherwise you need to update > > all socket users in user space. Other that that this looks good to me. > > What is wrong that we need such control to be done in userspace? I don't think my emails reached the list so sending it again. Ville: Its the other way round. With this approach and the default value, only the HID userspace socket needs to be modified - nothing else. Luiz: The HID devices can send data even when in sniff mode and hence we need to change the userspace L2CAP socket option. While sending data without exiting sniff mode for A2DP for example, causes problems as explained in the commit message. > > > -- > Luiz Augusto von Dentz > Computer Engineer