Return-Path: <cyrus@holtmann.org>
Date: Thu, 5 May 2011 01:34:17 -0700
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 00/13] Discovery Cleanup - Step 1
Message-ID: <20110505083417.GB24639@jh-x301>
References: <BANLkTin_qd=-3-3undR-Rcx0BG9t=Z3nVQ@mail.gmail.com>
 <1304458330-21499-1-git-send-email-claudio.takahasi@openbossa.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
In-Reply-To: <1304458330-21499-1-git-send-email-claudio.takahasi@openbossa.org>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Claudio,

On Tue, May 03, 2011, Claudio Takahasi wrote:
> This patch series is the first step to cleanup the device discovery
> procedure. The main changes are:
>   - Unify advertising reports and inquiry results: mgmt sends
>     one device found event
>   - Logic improvement/cleanup: device found
>   - Move EIR functions to a new file
>   - Add BDADDR type constants: necessary L2CAP connections and bonding
> 
> 
> 
> Bruna Moreira (3):
>   Remove btd_event_advertising_report
>   Replace EIR_DATA_LENGTH with HCI_MAX_EIR_LENGTH
>   Drop variable EIR length
> 
> Claudio Takahasi (10):
>   Move EIR related functions to a new file
>   Add Bluetooth address type definition
>   Initial device found cleanup
>   Move legacy verification to a new function
>   Cleanup read name and alias from storage
>   Don't resolve name if the name is in the storage
>   Unify inquiry results and advertises
>   Fix memory leak of EIR data
>   Change the order to write/read the remote's name
>   Cleanup inserting new device found entry
> 
>  Makefile.am       |    2 +-
>  lib/bluetooth.h   |    4 +
>  plugins/hciops.c  |  202 +++++----------------------------
>  plugins/mgmtops.c |    3 +-
>  src/adapter.c     |  182 +++++++++++++++++++-----------
>  src/adapter.h     |    9 +-
>  src/eir.c         |  328 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/eir.h         |   41 +++++++
>  src/event.c       |  224 +-----------------------------------
>  src/event.h       |    5 +-
>  src/sdpd.h        |   14 ---
>  11 files changed, 530 insertions(+), 484 deletions(-)
>  create mode 100644 src/eir.c
>  create mode 100644 src/eir.h

These patches don't seem to apply any more after I applied Andr?s
patches. (also, I can't really try applying anything else except 1/13
since 2/13 is already the address type patch which is still being
discussed).

Johan