Return-Path: Date: Mon, 2 May 2011 18:47:28 -0300 From: "Gustavo F. Padovan" To: Anderson Briglia Cc: Elvis =?iso-8859-1?Q?Pf=FCtzenreuter?= , Johan Hedberg , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Remove btio.c compilation warning Message-ID: <20110502214728.GD2364@joana> References: <4dbf1776.0bd9650a.1733.7e99@mx.google.com> <20110502211537.GA17551@jh-x301> <0074C043-DBA7-4BE3-9D9E-9CEC1FFA4096@signove.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Briglia, * Anderson Briglia [2011-05-02 18:33:11 -0300]: > Hi all, > > On Mon, May 2, 2011 at 6:23 PM, Elvis Pf?tzenreuter wrote: > > On May 2, 2011, at 6:15 PM, Johan Hedberg wrote: > > > >> Hi Briglia, > >> > >> On Mon, May 02, 2011, anderson.briglia@openbossa.org wrote: > >>> This patch fixes a compilation warning regarding btio/btio.c > >>> compilation. > >>> --- > >>> btio/btio.c | ? ?2 +- > >>> 1 files changed, 1 insertions(+), 1 deletions(-) > >>> > >>> diff --git a/btio/btio.c b/btio/btio.c > >>> index 6d71b90..8f166cc 100644 > >>> --- a/btio/btio.c > >>> +++ b/btio/btio.c > >>> @@ -800,7 +800,7 @@ static gboolean l2cap_get(int sock, GError **err, BtIOOption opt1, > >>> ? ? ?uint8_t dev_class[3]; > >>> ? ? ?uint16_t handle; > >>> ? ? ?socklen_t len; > >>> - ? ?gboolean flushable; > >>> + ? ?gboolean flushable = TRUE; > >>> > >>> ? ? ?len = sizeof(l2o); > >>> ? ? ?memset(&l2o, 0, len); > >> > >> I don't get the warning with my compiler, so in addition to the already > >> requested compiler logs please also mention the compiler version. Also, > >> the value should default to FALSE and not TRUE. > > > > > It looks like a false alarm from gcc 4.5.2 (Ubuntu Natty), or at least I feel > > like it (got it here, too). If you agree, a bug ticket could be submitted to them. > > It makes sense. This "fake" warning appears after I upgraded to Ubuntu > Natty. Anyway, you guys could make a quick test adding > --enable-maintainer-mode flag to configure. We always have maintainer mode enabled and I can't see anything wrong here. It's probably your ubuntu. -- Gustavo F. Padovan http://profusion.mobi