Return-Path: <cyrus@holtmann.org>
Subject: Re: [PATCH openobex 1/3] Add transport format member in fdobex_data
 struct. Support STREAM and SEQPACKET transport format.
From: Marcel Holtmann <marcel@holtmann.org>
To: Nami <nami.li@atheros.com>
Cc: linux-bluetooth@vger.kernel.org, haijun@qca.qualcomm.com,
	openobex-users@lists.sourceforge.net
Date: Mon, 20 Jun 2011 09:43:10 -0700
In-Reply-To: <1308548849-11615-1-git-send-email-nami.li@atheros.com>
References: <1308548849-11615-1-git-send-email-nami.li@atheros.com>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <1308588193.2196.34.camel@aeonflux>
Mime-Version: 1.0
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Nami,

>  include/openobex/obex_const.h |    4 ++++
>  lib/fdobex.h                  |    1 +
>  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/include/openobex/obex_const.h b/include/openobex/obex_const.h
> index cb7afeb..8acee91 100644
> --- a/include/openobex/obex_const.h
> +++ b/include/openobex/obex_const.h
> @@ -302,6 +302,10 @@ enum obex_rsp_mode {
>    OBEX_RSP_MODE_SINGLE = 1, /**< single response mode (SRM) */
>  };
> 
> +enum fdobex_transport_format{
> +	 FDOBEX_MT_STREAM ,
> +	 FDOBEX_MT_SEQPACKET
> +};

can I ask again why we should be doing this. Especially for the FdOBEX
transport this is pointless. You are getting a file descriptor in the
first place. It does not have to be a socket.

And in the case this is really a socket, then you can just use SO_TYPE
to read the current type of the socket.

If it is not a socket, then it needs to treated as stream anyway.

Regards

Marcel