Return-Path: Message-ID: In-Reply-To: <1307114762.2669.125.camel@novo.hadess.net> References: <1298628292-8842-1-git-send-email-ospite@studenti.unina.it> <1298628292-8842-4-git-send-email-ospite@studenti.unina.it> <1304644488.16101.28.camel@novo.hadess.net> <20110507011412.ba0ad1e9.ospite@studenti.unina.it> <1304787442.2427.11.camel@novo.hadess.net> <20110603135904.096660bc.ospite@studenti.unina.it> <1307114762.2669.125.camel@novo.hadess.net> Date: Fri, 3 Jun 2011 11:56:38 -0400 Subject: Re: [PATCH v2 3/3] Add sixaxis plugin: USB pairing and LEDs settings From: simon@mungewell.org To: "Bastien Nocera" Cc: "Antonio Ospite" , linux-bluetooth@vger.kernel.org, linux-input@vger.kernel.org, "Jim Paris" , "Ranulf Doswell" , "Pascal A . Brisset" , "Marcin Tolysz" , "Christian Birchinger" , "Filipe Lopes" , "Alan Ott" , "Mikko Virkkila" MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-input-owner@vger.kernel.org List-ID: Just generally on this subject, should the code which performs the USB 'write' be in 'hid-sony.c' rather than the BT core. It's possible that the Sixaxis or other compatible controllers will be only USB connected and BT might not even exist on the system. If/When I manage to do some work on rumble support, we will probably need to ensure that a 'hid-sonyff.c' is aware of any LED settings otherwise it might overwrite them when setting the rumble. Simon.