Return-Path: From: Bartosz Szatkowski To: linux-bluetooth@vger.kernel.org Cc: Bartosz Szatkowski Subject: [PATCH BlueZ] Add SetRemoteProperty method for OOB mechanism Date: Mon, 4 Jul 2011 16:49:45 +0200 Message-Id: <1309790985-32143-1-git-send-email-bulislaw@linux.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: It might be necessary in use cases when there is OOB pairing and some portion of remote device properties is needed before profiles are connected. For now only class of device is supported. --- doc/oob-api.txt | 10 ++++++++++ plugins/dbusoob.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+), 0 deletions(-) diff --git a/doc/oob-api.txt b/doc/oob-api.txt index d838712..e15fc29 100644 --- a/doc/oob-api.txt +++ b/doc/oob-api.txt @@ -36,3 +36,13 @@ Methods array{byte} hash, array{byte} randomizer ReadLocalData() Possible errors: org.bluez.Error.Failed org.bluez.Error.InvalidArguments + + void SetRemoteProperty(string address, string property, + variant value) + + This method adds new property for device with specified + address, to be used when device is created. + For now only Class of device is supported. + + Possible errors: org.bluez.Error.Failed + org.bluez.Error.InvalidArguments diff --git a/plugins/dbusoob.c b/plugins/dbusoob.c index 2c03780..c9ca57a 100644 --- a/plugins/dbusoob.c +++ b/plugins/dbusoob.c @@ -43,6 +43,7 @@ #include "event.h" #include "error.h" #include "oob.h" +#include "storage.h" #define OOB_INTERFACE "org.bluez.OutOfBand" @@ -153,6 +154,57 @@ static DBusMessage *add_remote_data(DBusConnection *conn, DBusMessage *msg, return g_dbus_create_reply(msg, DBUS_TYPE_INVALID); } +static DBusMessage *set_remote_property(DBusConnection *conn, DBusMessage *msg, + void *data) +{ + struct btd_adapter *adapter = data; + DBusMessageIter iter, sub; + char *addr, *property; + bdaddr_t local, peer; + + if (!dbus_message_iter_init(msg, &iter)) + return btd_error_invalid_args(msg); + + if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING) + return btd_error_invalid_args(msg); + + dbus_message_iter_get_basic(&iter, &addr); + dbus_message_iter_next(&iter); + + if (bachk(addr)) + return btd_error_invalid_args(msg); + + adapter_get_address(adapter, &local); + str2ba(addr, &peer); + + if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING) + return btd_error_invalid_args(msg); + + dbus_message_iter_get_basic(&iter, &property); + dbus_message_iter_next(&iter); + + if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) + return btd_error_invalid_args(msg); + + dbus_message_iter_recurse(&iter, &sub); + + if (g_str_equal("Class", property)) { + uint32_t class; + + if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_UINT32) + return btd_error_invalid_args(msg); + + dbus_message_iter_get_basic(&sub, &class); + + if (write_remote_class(&local, &peer, class) < 0) + return btd_error_failed(msg, "Request failed"); + } else { + return btd_error_invalid_args(msg); + } + + return g_dbus_create_reply(msg, DBUS_TYPE_INVALID); +} + static DBusMessage *remove_remote_data(DBusConnection *conn, DBusMessage *msg, void *data) { @@ -177,6 +229,7 @@ static DBusMessage *remove_remote_data(DBusConnection *conn, DBusMessage *msg, static GDBusMethodTable oob_methods[] = { {"AddRemoteData", "sayay", "", add_remote_data}, + {"SetRemoteProperty", "ssv", "", set_remote_property}, {"RemoveRemoteData", "s", "", remove_remote_data}, {"ReadLocalData", "", "ayay", read_local_data, G_DBUS_METHOD_FLAG_ASYNC}, -- 1.7.4.1