Return-Path: MIME-Version: 1.0 In-Reply-To: <1312984225.3373.118.camel@aeonflux> References: <1311623405-31108-1-git-send-email-andre.guedes@openbossa.org> <1311623405-31108-12-git-send-email-andre.guedes@openbossa.org> <1312984225.3373.118.camel@aeonflux> Date: Wed, 10 Aug 2011 10:42:17 -0400 Message-ID: Subject: Re: [PATCH v2 11/16] Bluetooth: Add 'eir_len' param to mgmt_device_found() From: Anderson Lizardo To: Marcel Holtmann Cc: Andre Guedes , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 List-ID: Hi Marcel/Andre, On Wed, Aug 10, 2011 at 9:50 AM, Marcel Holtmann wrote: > Hi Andre, > >> This patch adds a new parameter to mgmt_device_found() to inform >> the length of 'eir' pointer. >> >> EIR data from LE advertising report event doesn't have a fixed length >> as EIR data from extended inquiry result event does. We needed to >> change mgmt_device_found() so it copies 'eir_len' bytes instead of >> HCI_MAX_EIR_LENGTH. > > what is the max EIR length for LE? Is it more than with BR/EDR. Or is it > just variable length? >From page 1735: "The data consists of a significant part and a non-significant part. [...] The non-significant part extends the Advertising and Scan Response data to 31 octets and shall contain all-zero octets." So actually it is not variable length, it has 31 octets, with the non-significant part zero padded. BR/EDR EIR, on the other hand is 240 bytes (with zero padding for non-significant part as well) Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil