Return-Path: Message-ID: <4E6746C4.90903@visionsystems.de> Date: Wed, 07 Sep 2011 12:26:12 +0200 From: Yegor Yefremov Reply-To: yegor_sub1@visionsystems.de MIME-Version: 1.0 To: linux-bluetooth@vger.kernel.org CC: Marcel Holtmann Subject: Re: [PATCH] hciattach: fix serial speed setting for wl1271 References: <4E64D1B4.9020300@visionsystems.de> In-Reply-To: <4E64D1B4.9020300@visionsystems.de> Content-Type: text/plain; charset=ISO-8859-15 List-ID: Am 05.09.2011 15:42, schrieb Yegor Yefremov: > override speed setting if firmware script issues serial settings command, > otherwise the value given in the firmware script will be overridden. > > Example: > > hciattach /dev/ttyO1 texas 115200 > > will fail, because /dev/ttyO1 will be opened with 115200 b/s, then > the firmware script will set the buadrate to 3000000 b/s, after UART init > hciattach.c will set the baudrate to 115200, so communication is broken. > > The only correct way is to set both speeds: > > hciattach -s 115200 /dev/ttyO1 texas 3000000 > > With this patch only initial speed must be specified. The former semantic > will be preserved in case the firmware script doesn't provide serial > settings action. > > Tested with wl1271 and firmware TIInit_7.2.31.bts > > Signed-off-by: Yegor Yefremov > --- > tools/hciattach.c | 2 +- > tools/hciattach.h | 2 +- > tools/hciattach_ti.c | 19 +++++++++++-------- > 3 files changed, 13 insertions(+), 10 deletions(-) > See this thread for more info: http://e2e.ti.com/support/low_power_rf/f/307/t/57254.aspx