Return-Path: Subject: Re: [PATCHv2 6/9] Bluetooth: Add definitions for L2CAP fixed channels From: Marcel Holtmann To: Mat Martineau Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi, pkrystad@codeaurora.org, andrei.emeltchenko@intel.com Date: Wed, 19 Oct 2011 15:02:54 -0700 In-Reply-To: References: <1319046247-3391-1-git-send-email-mathewm@codeaurora.org> <1319046247-3391-7-git-send-email-mathewm@codeaurora.org> <1319051041.15441.167.camel@aeonflux> Content-Type: text/plain; charset="UTF-8" Message-ID: <1319061777.15441.188.camel@aeonflux> Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Mat, > >> Symbolic fixed channel IDs will be used instead of magic numbers. > >> > >> Signed-off-by: Mat Martineau > >> --- > >> include/net/bluetooth/l2cap.h | 4 ++++ > >> 1 files changed, 4 insertions(+), 0 deletions(-) > >> > >> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h > >> index 4f4f318..b8b25f6 100644 > >> --- a/include/net/bluetooth/l2cap.h > >> +++ b/include/net/bluetooth/l2cap.h > >> @@ -119,6 +119,10 @@ struct l2cap_conninfo { > >> #define L2CAP_FCS_NONE 0x00 > >> #define L2CAP_FCS_CRC16 0x01 > >> > >> +/* L2CAP fixed channels */ > >> +#define L2CAP_FC_L2CAP 0x02 > >> +#define L2CAP_FC_A2MP 0x08 > >> + > > > > while you are at it, please add the known fixed channels for SMP and LE > > signaling here. They should be in use already somewhere ;) > > The channel mask wasn't a problem at the recent UPF, since the LE > fixed channels are only used on LE connections and the info > request/response are only relevant for BR/EDR. It seems like these LE > fixed channel bits should not be set when sending an info response or > checked when processing an info response. > > Do you still want me to add them? I have not looked at all LE patches and this might need some coordination, but in general yes, I like to have a proper set of fixed channel value here. A good implementation would check these first. Even if with LE, the LE link manager connection implies LE support, I rather have a proper fixed channel mask here. That said, if you just wanna send a patch that updates this later on, I am fine with that as well. Regards Marcel