Return-Path: <cyrus@holtmann.org>
Date: Thu, 13 Oct 2011 14:25:44 -0300
From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: Claudio Takahasi <claudio.takahasi@openbossa.org>,
	"Gustavo F. Padovan" <padovan@profusion.mobi>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Fix permission of enable_le param
Message-ID: <20111013172544.GA31083@samus.indt.org>
References: <1318359533-7640-1-git-send-email-padovan@profusion.mobi>
 <CAKT1EBf7fXR61TRGoKx6N0kKerXdmewphL-yu3J6vJjqbehNkA@mail.gmail.com>
 <CAJdJm_N6L5bYctkivfDgfPnuHEATwgLC+d4gDW+5P1iRP5+vPQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <CAJdJm_N6L5bYctkivfDgfPnuHEATwgLC+d4gDW+5P1iRP5+vPQ@mail.gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Lizardo,

On 16:28 Tue 11 Oct, Anderson Lizardo wrote:
> Hi,
> 
> On Tue, Oct 11, 2011 at 3:33 PM, Claudio Takahasi
> <claudio.takahasi@openbossa.org> wrote:
> > On Tue, Oct 11, 2011 at 3:58 PM, Gustavo F. Padovan
> > <padovan@profusion.mobi> wrote:
> >> With 0444 it is impossible to change the param, changing it to 0644.
> >
> > If you allow changing the "enable_le" parameter dynamically it is also
> > necessary check the controller features and update the LE host
> > supported bit(if necessary).
> > I am afraid that allowing to change it dynamically will break the
> > consistency: what is gonna happen with the active operations(discovery
> > & connections)?
> >
> > In our backlog we were planning to check LE host supported bit to
> > allow/block LE connections or any other feature related to LE.
> 
> For me, it makes more sense to have bluez set LE host supported bit on
> start, and have no "enable_le" module parameter at all.

While I agree with this, IMHO we are not ready for it yet, I would wait
for all the major functionalities to be integrated before removing it.

And there's the minor point that sometimes for testing and qualification
you have the hardware but don't want to have LE enabled.

> 
> I think just allowing to change enable_le after the module has been
> loaded will not work as expected.
> 
> Regards,
> -- 
> Anderson Lizardo
> Instituto Nokia de Tecnologia - INdT
> Manaus - Brazil
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers,
-- 
Vinicius