Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1318359533-7640-1-git-send-email-padovan@profusion.mobi> Date: Tue, 11 Oct 2011 16:28:51 -0400 Message-ID: Subject: Re: [PATCH] Bluetooth: Fix permission of enable_le param From: Anderson Lizardo To: Claudio Takahasi Cc: "Gustavo F. Padovan" , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Tue, Oct 11, 2011 at 3:33 PM, Claudio Takahasi wrote: > On Tue, Oct 11, 2011 at 3:58 PM, Gustavo F. Padovan > wrote: >> With 0444 it is impossible to change the param, changing it to 0644. > > If you allow changing the "enable_le" parameter dynamically it is also > necessary check the controller features and update the LE host > supported bit(if necessary). > I am afraid that allowing to change it dynamically will break the > consistency: what is gonna happen with the active operations(discovery > & connections)? > > In our backlog we were planning to check LE host supported bit to > allow/block LE connections or any other feature related to LE. For me, it makes more sense to have bluez set LE host supported bit on start, and have no "enable_le" module parameter at all. I think just allowing to change enable_le after the module has been loaded will not work as expected. Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil