Return-Path: Date: Fri, 7 Oct 2011 23:25:22 +0300 From: Johan Hedberg To: Vinicius Costa Gomes Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH BlueZ] Fix using the attribute struct for encoding ATT pdus Message-ID: <20111007202522.GA23669@fusion.localdomain> References: <1317911897-6567-1-git-send-email-vinicius.gomes@openbossa.org> <1317924108-25463-1-git-send-email-vinicius.gomes@openbossa.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1317924108-25463-1-git-send-email-vinicius.gomes@openbossa.org> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Vinicius, On Thu, Oct 06, 2011, Vinicius Costa Gomes wrote: > The enconding and decoding of ATT pdus should be kept as much > free of dependences from other parts of the code as possible, so > it can be used in many contexts. > > In this case, for encoding and decoding notifications and indications > we did have to pass an instance of an attribute instead of direct > values. > --- > attrib/att.c | 45 +++++++++++++++++++++++++-------------------- > attrib/att.h | 9 ++++++--- > src/attrib-server.c | 6 ++++-- > 3 files changed, 35 insertions(+), 25 deletions(-) Applied. Thanks. Johan