Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1317825160-21429-1-git-send-email-lkslawek@gmail.com> <1317825160-21429-4-git-send-email-lkslawek@gmail.com> <20111006094430.20945f35guft5q4g@mail.hendrik-sattler.de> Date: Thu, 6 Oct 2011 12:17:05 +0300 Message-ID: Subject: Re: [PATCH obexd 4/4] Simplify code for calling mime driver flush() From: Luiz Augusto von Dentz To: Slawomir Bochenski Cc: Hendrik Sattler , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Slawomir, On Thu, Oct 6, 2011 at 11:21 AM, Slawomir Bochenski wrote: > > obexd works as it should. The code is coping with this by doing a > buffering on behalf of a service driver if the service driver is not > using chkput. So from the service perspective it will be still put, > open, write, as the actual writing to mime driver is started at > obex_put_stream_start. Except that we should not buffer more than MTU size, also this is completely the opposite of what we should be doing which is to copy buffers as little as possible. As for broken I mean the design is broken since if the service does not implement .put obexd should return not implemented right in the first packet, actually .put is completely useless right now since it is basically as calling a .flush but it does useless checks. -- Luiz Augusto von Dentz