Return-Path: MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 25 Nov 2011 15:55:20 +0100 Message-ID: Subject: Re: PBAP: Generate cache using absolute path instead of relative path. From: Slawomir Bochenski To: Anders Widen Cc: linux-bluetooth Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Fri, Nov 25, 2011 at 3:49 PM, Anders Widen wrote: > Hi! > > Possible error? > > Looking at the PBAP Specification P.27 > > "5.3.3 Name > This header specifies the name of the folder to be retrieved. The > value shall not include > any path information, since the PullvCardListing function uses > relative paths. An empty > name header may be sent to retrieve the folder that is the current directory." > > and then in the backend implementations: > /plugins/phonebook-tracker.c > /plugins/phonebook-ebook.c > > both use absolute paths in the implementation of: > > phonebook_create_cache(const char *name, phonebook_entry_cb entry_cb, > ? ? ?phonebook_cache_ready_cb ready_cb, void *user_data, int *err) > > > Is there something in PBAP Core I've missed? > I looked for concats of the current_folder but it seems to pass the > information to the implementation raw. I guess path is generated in pbap_get(). There is type comparison for VCARDLISTING_TYPE and then the stored name is built from current path and given name. -- Slawomir Bochenski