Return-Path: Date: Mon, 21 Nov 2011 14:46:36 -0200 From: Gustavo Padovan To: Emeltchenko Andrei Cc: linux-bluetooth@vger.kernel.org Subject: Re: [RFC 1/3] Bluetooth: Use queue in the device list Message-ID: <20111121164636.GI2552@joana> References: <1321457422-31641-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1321457422-31641-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, * Emeltchenko Andrei [2011-11-16 17:30:20 +0200]: > From: Andrei Emeltchenko > > Use queue instead of stack discipline for device list. When processing > dev_list with list_for_each* devices will be prosessed in order they > were added (Usually BR/EDR first and AMP later). > > Also output from hciconfig looks nicer :-) > > Signed-off-by: Andrei Emeltchenko > --- > net/bluetooth/hci_core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > index cf18f6d..aee76fd 100644 > --- a/net/bluetooth/hci_core.c > +++ b/net/bluetooth/hci_core.c > @@ -1452,7 +1452,7 @@ int hci_register_dev(struct hci_dev *hdev) > > sprintf(hdev->name, "hci%d", id); > hdev->id = id; > - list_add(&hdev->list, head); > + list_add_tail(&hdev->list, head); > > atomic_set(&hdev->refcnt, 1); > spin_lock_init(&hdev->lock); Applied, thanks. Gustavo