Return-Path: Date: Wed, 16 Nov 2011 16:11:00 -0200 From: Gustavo Padovan To: johan.hedberg@gmail.com Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH v2] Bluetooth: Create a unique mgmt error code hierarchy Message-ID: <20111116181100.GF16865@joana> References: <1321021134-31809-2-git-send-email-johan.hedberg@gmail.com> <1321027800-353-1-git-send-email-johan.hedberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1321027800-353-1-git-send-email-johan.hedberg@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Johan, * johan.hedberg@gmail.com [2011-11-11 18:10:00 +0200]: > From: Johan Hedberg > > The management protocol uses a single byte for error codes (aka command > status). In some places this value is directly copied from HCI and in > other a POSIX error number is used. This makes it impossible for > user-space to uniquily decipher the meaning of an error. > > To solve this issue a new mgmt-specific set of error codes is added > along with a conversion table for HCI status values. > > Signed-off-by: Johan Hedberg > --- > v2: Use ARRAY_SIZE() instead of a custom NELEM() > > include/net/bluetooth/mgmt.h | 17 +++ > net/bluetooth/mgmt.c | 315 ++++++++++++++++++++++++++++++------------ > 2 files changed, 241 insertions(+), 91 deletions(-) It doesn't apply anymore, please rebase. Gustavo