Return-Path: <cyrus@holtmann.org>
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: linux-bluetooth@vger.kernel.org
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Subject: [RFC 0/2] gdbus: Add names to arguments
Date: Tue, 15 Nov 2011 03:43:51 -0200
Message-Id: <1321335833-16907-1-git-send-email-lucas.demarchi@profusion.mobi>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hey, this is an RFC regarding the following issue: people doing clients for
BlueZ/oFono/ConnMan would like to be able to see the argument names in the XML
generated by D-Bus introspection. It allows better code generated by codegen
tools.

First patch changes gdbus to allow the argument names to be added and the
second patch takes a random interface to show how it would like. The bad thing
is that all the interfaces would need to be changed to accomplish the goal of
having the names in introspection.

Below a piece of the XML generated by introspection before this patch:

	<interface name="org.bluez.Manager">
		<method name="GetProperties">
			<arg type="a{sv}" direction="out"/>
		</method>
		<method name="DefaultAdapter">
			<arg type="o" direction="out"/>
		</method>
		<method name="FindAdapter">
			<arg type="s" direction="in"/>
			<arg type="o" direction="out"/>
		</method>
		<...>
	</interface>

And after it:

	<interface name="org.bluez.Manager">
		<method name="GetProperties">
			<arg type="a{sv}" direction="out"/>
		</method>
		<method name="DefaultAdapter">
			<arg type="o" direction="out"/>
		</method>
		<method name="FindAdapter">
			<arg name="pattern" type="s" direction="in"/>
			<arg type="o" direction="out"/>
		</method>
		<...>
	</interface>


Regards,
Lucas De Marchi

Lucas De Marchi (2):
  gdbus: Add argument name to introspection xml
  manager: add argument name

 gdbus/gdbus.h  |    1 +
 gdbus/object.c |   37 ++++++++++++++++++++++++++-----------
 src/manager.c  |    3 ++-
 3 files changed, 29 insertions(+), 12 deletions(-)

-- 
1.7.7.3