Return-Path: MIME-Version: 1.0 In-Reply-To: References: Date: Sat, 12 Nov 2011 01:49:14 +0200 Message-ID: Subject: Re: Out of tree plugins From: Alon Bar-Lev To: Lucas De Marchi Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Sat, Nov 12, 2011 at 1:42 AM, Lucas De Marchi wrote: >> If you do not expose the plugin.h (install it as part of bluez package >> installation), >> it means that all plugins must be in tree. >> Or you require people to checkout bluez sources and compile against >> it, this is none standard approach. >> Same for other header files which may be used by out of tree plugins. > > The goal here is not to be able to build out of tree, but just as > module or builtin. > Then this is a bug and should be treated as such. In ConnMan/oFono we > prefix the functions and then we use a glob in the linker script. I > think we don't have that in bluez because there aren't that many > external plugins. Well, so there will be no out of tree plugins. So what is the process to get complex module such as sixaxis into tree? Adding the udev dependency to bluetoothd is ugly. Bloating the bluetoothd with a lot of more code is ugly. So at the very least the symbol issues should be resolved, so the plugin can be built into its own .so. Alon.