Return-Path: MIME-Version: 1.0 In-Reply-To: <20111215121700.GA10535@x220> References: <1323703867-20577-1-git-send-email-bulislaw@linux.com> <1323703867-20577-4-git-send-email-bulislaw@linux.com> <20111215115009.GB8056@x220> <20111215121700.GA10535@x220> Date: Thu, 15 Dec 2011 13:45:09 +0100 Message-ID: Subject: Re: [PATCH obexd 4/4] Add support for PullMessagesListing in MAP client From: Bartosz Szatkowski To: Bartosz Szatkowski , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Thu, Dec 15, 2011 at 1:17 PM, Johan Hedberg wrote: > Hi Bartosz, > > On Thu, Dec 15, 2011, Bartosz Szatkowski wrote: >> > The name should be GetMessageListing and not GetMessagesListing (the >> > latter isn't really proper english). I went ahead and changed it through >> > a separate patch since I didn't notice before having already applied >> > your patch. Also, all this seems to be missing from the API >> > documentation (doc/*). Please send a patch for that. >> >> The function name is "GetMessagesListing" in spec. >> There is no doc as at the moment there is no apparams handling and no >> xml parsing, so I'll send patch with doc when we reach full >> functionality. > > So the plan is to return something else than the raw XML that MAP > provides? In that case I don't think it's necessary to hold on to the > exact spec naming of these functions. E.g. GetMessages or GetMessageList > might make more sense in the case that you return a pre-parsed > list/structure of some kind. > > Johan We planned to return dict {field: value}. Generally I don't care much about this name - we can go with GetMessageListing, as I seem to use both forms without noticing it anyway. -- Pozdrowienia - Cheers, Bartosz Szatkowski