Return-Path: MIME-Version: 1.0 In-Reply-To: <20111215115405.GA9571@x220> References: <1323703867-20577-1-git-send-email-bulislaw@linux.com> <1323703867-20577-4-git-send-email-bulislaw@linux.com> <20111215115009.GB8056@x220> <20111215115405.GA9571@x220> Date: Thu, 15 Dec 2011 12:56:30 +0100 Message-ID: Subject: Re: [PATCH obexd 4/4] Add support for PullMessagesListing in MAP client From: Bartosz Szatkowski To: Bartosz Szatkowski , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Thu, Dec 15, 2011 at 12:54 PM, Johan Hedberg wrote: > Hi, > > On Thu, Dec 15, 2011, Johan Hedberg wrote: >> On Mon, Dec 12, 2011, Bartosz Szatkowski wrote: >> > +   { "GetMessagesListing", "sa{ss}", "s",  map_get_messages_listing, >> > +                                           G_DBUS_METHOD_FLAG_ASYNC }, >> >> The name should be GetMessageListing and not GetMessagesListing (the >> latter isn't really proper english). > > And now I notice that the spec. actually uses the plural form (which > still sounds to me like strange English). All this fuss could have been > avoided if we had had a proper discussion of the API beforehand and had > the documentation in place before these patches. > > Johan I've sent API before I've started to work on patches - only Luiz responded, and there was discussion on other matters ... -- Pozdrowienia - Cheers, Bartosz Szatkowski