Return-Path: MIME-Version: 1.0 In-Reply-To: <1328025524.1955.219.camel@aeonflux> References: <1327999384-16094-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <1327999384-16094-2-git-send-email-Andrei.Emeltchenko.news@gmail.com> <20120131130242.GB7660@aemeltch-MOBL1> <1328022697.1955.217.camel@aeonflux> <1328025524.1955.219.camel@aeonflux> Date: Tue, 31 Jan 2012 15:49:19 -0200 Message-ID: Subject: Re: [RESEND 1/3] Bluetooth: Use cancel_work instead of cancel_work_sync From: Ulisses Furquim To: Marcel Holtmann Cc: Emeltchenko Andrei , Andre Guedes , linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 List-ID: Hi Marcel, On Tue, Jan 31, 2012 at 1:58 PM, Marcel Holtmann wrot= e: > Hi Ulisses, > >> >> > > - =A0 =A0 =A0 cancel_delayed_work_sync(&conn->disc_work); >> >> > > + =A0 =A0 =A0 cancel_delayed_work(&conn->disc_work); >> >> > >> >> > I'm afraid we must use _sync variant here. disc_work is not suppose= d to >> >> > be running after hci_conn is deleted. >> >> > >> >> > BTW, I believe we already addressed this issue in patches [PATCH 1/= 2] >> >> > Bluetooth: Fix potential deadlock and [PATCH 2/2] Bluetooth: Remove >> >> > unneeded locking. These patches are now pushed upstream. Could you >> >> >> >> I will check those patches from upstream and let you know. >> > >> > crap, I just acked these. >> > >> > Johan, forget about my acks and just ignore them. Lets wait until we g= et >> > a clean new series. >> > >> This change is really wrong because we're on the delete path and Andre >> sent other patches which I'm almost sure will address this problem. > > lets do it this way, I only look at final patches that you and Andrei > signed off / acked. Sure, we can do that this way. Regards, --=20 Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs