Return-Path: Date: Tue, 3 Jan 2012 00:48:22 +0200 From: Johan Hedberg To: Marcel Holtmann Cc: Andre Guedes , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Fix mgmt_stop_discovery_failed() Message-ID: <20120102224822.GA7603@fusion.localdomain> References: <1325533853-10101-1-git-send-email-andre.guedes@openbossa.org> <1325543108.1965.403.camel@aeonflux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1325543108.1965.403.camel@aeonflux> List-ID: On Mon, Jan 02, 2012, Marcel Holtmann wrote: > > Stop Discovery Command Status Event should use mgmt status code. > > > > Signed-off-by: Andre Guedes > > --- > > net/bluetooth/mgmt.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > > index 2540944..fb0b15e 100644 > > --- a/net/bluetooth/mgmt.c > > +++ b/net/bluetooth/mgmt.c > > @@ -2756,7 +2756,7 @@ int mgmt_stop_discovery_failed(struct hci_dev *hdev, u8 status) > > if (!cmd) > > return -ENOENT; > > > > - err = cmd_status(cmd->sk, hdev->id, cmd->opcode, status); > > + err = cmd_status(cmd->sk, hdev->id, cmd->opcode, mgmt_status(status)); > > mgmt_pending_remove(cmd); > > patch does look reasonable to me, but I am not this is the expected > behavior. I leave this up to Johan to ACK or NAK. Looks good to me. Acked-by: Johan Hedberg Johan