Return-Path: Date: Tue, 21 Feb 2012 21:24:32 +0200 From: Johan Hedberg To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCHv1 00/14] Bluetooth: Change socket lock to l2cap_chan lock Message-ID: <20120221192432.GA9980@x220.P-661HNU-F1> References: <1329821707-11817-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1329821707-11817-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, On Tue, Feb 21, 2012, Andrei Emeltchenko wrote: > From: Andrei Emeltchenko > > Changing socket lock to L2CAP chan lock in L2CAP code. Needed for implementing > protocol above L2CAP without creating sockets. > > Changes: > * PATCHv1: Added extra line (per Gustavo comment) > * RFCv6: Same code but patches 2,3 and 4 from RFCv5 are merged together > following recommendations from review. > * RFCv5: Fixed locking bug in l2cap_data_channel, added locks in > l2cap_sock_shutdown function, fixed several styles issues. > * RFCv4: Better split patches so they looks more clear and obvious, > taking coments about naming change and delete unused vars. See diff change > from the previous version below: > * RFCv3: Split the big patch to several small (I believe logical) chunks, > remove unneded locks from cleanup_listen, use the same arguments for > locked/unlocked socket error functions. > * RFCv2: Convert l2cap channel list back to mutex from RCU list. > > Andrei Emeltchenko (14): > Bluetooth: trivial: Fix long line > Bluetooth: Revert to mutexes from RCU list > Bluetooth: Add l2cap_chan_lock > Bluetooth: Add locked and unlocked state_change > Bluetooth: Add socket error function > Bluetooth: Add unlocked __l2cap_chan_add function > Bluetooth: Use chan lock in timers > Bluetooth: Use chan lock in L2CAP sig commands > Bluetooth: Use chan lock in L2CAP conn start > Bluetooth: Use chan lock in receiving data > Bluetooth: Change locking logic for conn/chan ready > Bluetooth: Change locking logic in security_cfm > Bluetooth: Use l2cap chan lock in socket connect > Bluetooth: Remove socket lock check > > include/net/bluetooth/l2cap.h | 11 ++ > net/bluetooth/l2cap_core.c | 392 +++++++++++++++++++++++++---------------- > net/bluetooth/l2cap_sock.c | 34 +++- > 3 files changed, 281 insertions(+), 156 deletions(-) Patches 1-5 have been applied to my bluetooth-next tree, so no need to resend them. Thanks. Johan