Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1329821707-11817-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> <1329821707-11817-13-git-send-email-Andrei.Emeltchenko.news@gmail.com> <20120221175602.GC22229@joana> Date: Tue, 21 Feb 2012 19:18:08 -0200 Message-ID: Subject: Re: [PATCHv1 12/14] Bluetooth: Change locking logic in security_cfm From: Ulisses Furquim To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, On Tue, Feb 21, 2012 at 6:44 PM, Andrei Emeltchenko wrote: > Hi Gustavo, > > On Tue, Feb 21, 2012 at 7:56 PM, Gustavo Padovan wrote: >> * Andrei Emeltchenko [2012-02-21 12:55:05 +0200]: >> >>> From: Andrei Emeltchenko >>> >>> Change bh_ locking functions to mutex_locks since we can now sleep. >>> >>> Signed-off-by: Andrei Emeltchenko > >> I don't like the idea of this locking change in multiple separate patches, it >> could put the stack in a broken and racy state if we stop in the middle of >> these patches. >> I would say to merge all these patches into one, they were a lot reviewed >> alone, there is no problem in create a big one with all the changes together. > > I saw the same comments from Ulisses. I will merge all those patches > together and send new patch series. Well, yes, but Marcel wasn't really worried about it, though. It's good if we merge this soon and move on with other patches touching L2CAP code. Best regards, -- Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs