Return-Path: MIME-Version: 1.0 In-Reply-To: <1329241945-32414-3-git-send-email-anderson.lizardo@openbossa.org> References: <1329241945-32414-1-git-send-email-anderson.lizardo@openbossa.org> <1329241945-32414-3-git-send-email-anderson.lizardo@openbossa.org> Date: Wed, 15 Feb 2012 10:03:40 +0100 Message-ID: Subject: Re: [PATCH BlueZ 3/3] thermometer: Fix re-enabling notification/indication on reconnection From: Santiago Carot To: Anderson Lizardo Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Anderson, 2012/2/14 Anderson Lizardo : > If a result callback is not specified for gatt_write_char() it is > assumed that Write Command will be used. This is not valid for > Characteristic Descriptors, which only support Write Request. I'm not against this patch but from my point of view, I think this is a little obscure behaviour wich would deserve an advice coment in gatt.h due it isn't clear for anybody developping over GATT to guess it. On the other hand, _I remember another functions in gatt.h wich have similar double behaviour depending on the parameters provided in there, suach as gatt_discovery_primary, in wich a discover ALL primary service is done if the uuid is equal to NULL or disvovery service by UUID is done if uuid is provided, I think gatt_discover_char works in the same way. Maybe that having a good comments here could help to avoid this kind of errors in the future. Regards. Santiago