Return-Path: Message-ID: <1329184963.8143.2.camel@joe2Laptop> Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles From: Joe Perches To: Gustavo Padovan Cc: Marcel Holtmann , "David S. Miller" , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Mon, 13 Feb 2012 18:02:43 -0800 In-Reply-To: <20120213215603.GA27753@joana> References: <44b8744770a55924c68f8ad0ca274816d2d6148f.1329102581.git.joe@perches.com> <1329114913.28848.50.camel@aeonflux> <20120213215603.GA27753@joana> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-ID: On Mon, 2012-02-13 at 19:56 -0200, Gustavo Padovan wrote: > it is not really a good idea to change BT_INFO to > bt_info and BT_ERR to bt_err. I understand that capital letters are not the > standard here but such a change is painful for all Bluetooth developers and I > don't wanna give more trouble to them. Hello Gustavo. Standardization of use and style is a good thing. What kind of trouble is a case conversion? Out of tree modules? > I'm ok if we only change bluetooth.h here. I sent the patch I think appropriate. If you want to strip out only the parts you want, be my guest. cheers, Joe