Return-Path: Message-id: From: Jaganath To: Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org References: <1328182441-14892-1-git-send-email-jaganath.k@samsung.com> In-reply-to: Subject: Re: [PATCH obexd 3/4] irmc: Fix length parameter of strncpy Date: Thu, 09 Feb 2012 16:46:43 +0530 MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=iso-8859-1; reply-type=original Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Luiz, -------------------------------------------------- From: "Luiz Augusto von Dentz" Sent: Thursday, February 09, 2012 4:37 PM To: "Jaganath" Cc: Subject: Re: [PATCH obexd 3/4] irmc: Fix length parameter of strncpy > Hi Jaganath, > > On Fri, Feb 3, 2012 at 2:22 PM, Jaganath wrote: >> I checked IRMC spec and could not find any length restriction. >> For "sn" spec says "The format of the field is manufacturer dependent." >> and for "manu" and "model" the acceptable value is string. > > The patch is not exactly wrong, but I fear that if we really start > reading this information from somewhere, which I guess it is whole > point here, then this fixed length may need some change. Correct. This patch is just a fix to a static tool reported issue Regards Jaganath > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html