Return-Path: Date: Fri, 30 Mar 2012 03:54:56 -0300 From: Gustavo Padovan To: Keith Packard Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Marcel Holtmann , Johan Hedberg Subject: Re: [PATCH] Revert "Bluetooth: Always enable management interface" Message-ID: <20120330065456.GA9173@joana> References: <1332983958-2734-1-git-send-email-keithp@keithp.com> <20120329022839.GA26111@joana> <86r4wct9q7.fsf@sumi.keithp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <86r4wct9q7.fsf@sumi.keithp.com> List-ID: Hi Keith, * Keith Packard [2012-03-28 19:35:44 -0700]: > <#part sign=pgpmime> > On Wed, 28 Mar 2012 23:28:39 -0300, Gustavo Padovan wrote: > > > A consequence is that you'll need to use newer version of bluez, at least 4.99. > > Or call the bluetooth daemon (from a pre 4.99 version) with a parameter to > > disable the new interface: > > That's not OK -- you're breaking user space with this kernel change. I > know I get bashed every time I suggest that we 'fix' the kernel and > require new user space X bits... Can you try the following patch? It should fix the compatibility problem you had. Gustavo -- commit d21c1177b9cf067809ccee2746633cfea3a8b062 Author: Gustavo Padovan Date: Thu Mar 29 09:47:53 2012 -0300 Bluetooth: Fix userspace compatibility issue with mgmt interface To ensure that old user space versions do not accidentally pick up and try to use the management channel, use a different channel number. Reported-by: Keith Packard Acked-by: Johan Hedberg Acked-by: Marcel Holtmann Signed-off-by: Gustavo Padovan diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h index 344b0f9..ba7f148 100644 --- a/include/net/bluetooth/hci.h +++ b/include/net/bluetooth/hci.h @@ -1327,8 +1327,8 @@ struct sockaddr_hci { #define HCI_DEV_NONE 0xffff #define HCI_CHANNEL_RAW 0 -#define HCI_CHANNEL_CONTROL 1 #define HCI_CHANNEL_MONITOR 2 +#define HCI_CHANNEL_CONTROL 3 struct hci_filter { unsigned long type_mask;