Return-Path: Sender: "Gustavo F. Padovan" Date: Thu, 8 Mar 2012 02:33:21 -0300 From: Gustavo Padovan To: santosh nayak Cc: marcel@holtmann.org, davem@davemloft.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: Resend: [PATCH] Bluetooth: Fix Endian Bug. Message-ID: <20120308053320.GD3998@joana> References: <1330622196-12967-1-git-send-email-santoshprasadnayak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1330622196-12967-1-git-send-email-santoshprasadnayak@gmail.com> List-ID: Hi Santosh, * santosh nayak [2012-03-01 22:46:36 +0530]: > From: Santosh Nayak > > Fix network to host endian conversion for L2CAP chan id. > > Signed-off-by: Santosh Nayak > --- > net/bluetooth/l2cap_sock.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c > index 401d942..86d5067 100644 > --- a/net/bluetooth/l2cap_sock.c > +++ b/net/bluetooth/l2cap_sock.c > @@ -82,7 +82,7 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen) > } > > if (la.l2_cid) > - err = l2cap_add_scid(chan, la.l2_cid); > + err = l2cap_add_scid(chan, __le16_to_cpu(la.l2_cid)); This is kind weird, la.l2_cid comes from the user, so it is already in host endian. No need for convertions here. Gustavo