Return-Path: Date: Mon, 2 Apr 2012 12:46:33 +0300 From: Johan Hedberg To: Arik Nemtsov Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH v6 0/6] Implement ProximityReporter profiles Message-ID: <20120402094633.GA26168@x220> References: <1332879859-20268-1-git-send-email-arik@wizery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Arik, On Mon, Apr 02, 2012, Arik Nemtsov wrote: > ping? Don't top post please. > On Tue, Mar 27, 2012 at 22:24, Arik Nemtsov wrote: > > This patch-set implements the Link loss and Immediate Alert GATT > > server profiles. > > > > A few API calls are added/changed in preparation, the most notable of > > which is the addition of the remote-device to each GATT read/write callback. > > > > The new profiles are separated into their own files for clarity. > > > > A ProximityReporter D-Bus interface is registered for each remote device. > > Property queries and PropertyChanged notifications are implemented, in > > accordance to doc/proximity-api.txt. > > > > v5->6: Fix immalert bug on unregister path. Rename att-bluez.h to > > att-database.h. Rebase on latest master (Makefile.am changes). > > > > Arik Nemtsov (6): > > ?att: add remote btd_device to ATT read/write callbacks > > ?proximity: reporter: save global D-Bus connection > > ?proximity: reporter: move definitions to .h and add util function > > ?proximity: link loss: implement link loss server > > ?proximity: immediate alert: implement immediate alert server > > ?proximity: reporter: implement D-Bus API > > > > ?Makefile.am ? ? ? ? ? ?| ? ?4 +- > > ?attrib/att-database.h ?| ? 44 +++++++ > > ?attrib/att.h ? ? ? ? ? | ? 20 --- > > ?attrib/gatt-service.c ?| ? ?1 + > > ?plugins/gatt-example.c | ? ?4 +- > > ?proximity/immalert.c ? | ?289 +++++++++++++++++++++++++++++++++++++++++ > > ?proximity/immalert.h ? | ? 26 ++++ > > ?proximity/linkloss.c ? | ?337 ++++++++++++++++++++++++++++++++++++++++++++++++ > > ?proximity/linkloss.h ? | ? 26 ++++ > > ?proximity/reporter.c ? | ?250 ++++++++++++++++++++++++++---------- > > ?proximity/reporter.h ? | ? 16 +++ > > ?src/attrib-server.c ? ?| ? 20 ++- > > ?time/server.c ? ? ? ? ?| ? ?7 +- > > ?13 files changed, 946 insertions(+), 98 deletions(-) > > ?create mode 100644 attrib/att-database.h > > ?create mode 100644 proximity/immalert.c > > ?create mode 100644 proximity/immalert.h > > ?create mode 100644 proximity/linkloss.c > > ?create mode 100644 proximity/linkloss.h Firstly the patches do not apply: Applying: att: add remote btd_device to ATT read/write callbacks /home/jh/src/bluez/.git/rebase-apply/patch:61: new blank line at EOF. + fatal: 1 line adds whitespace errors. Patch failed at 0001 att: add remote btd_device to ATT read/write callbacks And secondly you haven't replied anything to Lizardos mail yet. Johan