Return-Path: Date: Wed, 30 May 2012 14:35:21 -0700 (PDT) From: Mat Martineau To: Gustavo Padovan , marcel@holtmann.org cc: linux-bluetooth@vger.kernel.org, Gustavo Padovan Subject: Re: [PATCH -v3 2/2] Bluetooth: Remove unused err var from l2cap_segment_sdu() In-Reply-To: <1338308957-17282-2-git-send-email-gustavo@padovan.org> Message-ID: References: <1338308957-17282-1-git-send-email-gustavo@padovan.org> <1338308957-17282-2-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Gustavo - On Tue, 29 May 2012, Gustavo Padovan wrote: > From: Gustavo Padovan > > Trivial fix, let the code cleaner. > > Signed-off-by: Gustavo Padovan > --- > net/bluetooth/l2cap_core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > index acd43aa..db54e2d 100644 > --- a/net/bluetooth/l2cap_core.c > +++ b/net/bluetooth/l2cap_core.c > @@ -2067,7 +2067,6 @@ static int l2cap_segment_sdu(struct l2cap_chan *chan, > struct sk_buff *skb; > u16 sdu_len; > size_t pdu_len; > - int err = 0; > u8 sar; > > BT_DBG("chan %p, msg %p, len %d", chan, msg, (int)len); > @@ -2126,7 +2125,7 @@ static int l2cap_segment_sdu(struct l2cap_chan *chan, > } > } > > - return err; > + return 0; > } > > int l2cap_chan_send(struct l2cap_chan *chan, struct msghdr *msg, size_t len, > -- > 1.7.10.2 This is fine. I have some other changes for l2cap_segment_sdu, but they don't use the err variable either. Reviewed-by: Mat Martineau -- Mat Martineau Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum