Return-Path: MIME-Version: 1.0 In-Reply-To: <1337940693-3417-5-git-send-email-mikel.astiz.oss@gmail.com> References: <1337940693-3417-1-git-send-email-mikel.astiz.oss@gmail.com> <1337940693-3417-5-git-send-email-mikel.astiz.oss@gmail.com> Date: Fri, 25 May 2012 13:50:03 +0300 Message-ID: Subject: Re: [PATCH obexd v1 04/16] client-doc: Add transfer event-reporting signals From: Luiz Augusto von Dentz To: Mikel Astiz Cc: linux-bluetooth@vger.kernel.org, Mikel Astiz Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Mikel, On Fri, May 25, 2012 at 1:11 PM, Mikel Astiz wrote: > From: Mikel Astiz > > These signals replace the old agent-based notification mechanism. > --- > ?doc/client-api.txt | ? ?9 +++++++++ > ?1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/doc/client-api.txt b/doc/client-api.txt > index cc25543..527df05 100644 > --- a/doc/client-api.txt > +++ b/doc/client-api.txt > @@ -322,6 +322,15 @@ Signals ? ? ? ? ? ?PropertyChanged(string name, variant value) > ? ? ? ? ? ? ? ? ? ? ? ?This signal indicates a changed value of the given > ? ? ? ? ? ? ? ? ? ? ? ?property. > > + ? ? ? ? ? ? ? void Complete() > + > + ? ? ? ? ? ? ? ? ? ? ? Informs that the transfer has completed successfully. > + > + ? ? ? ? ? ? ? void Error(string message) > + > + ? ? ? ? ? ? ? ? ? ? ? Informs that the transfer has been terminated because > + ? ? ? ? ? ? ? ? ? ? ? of some error. > + To avoid any possible confusion I would leave a single signal to tell it is complete e.g. Complete(string message), as for the error Johan suggested something more meaningful like D-Bus error which both error code and error message e.g. Complete(string code, string message), actually maybe we should give some other detail when the transfer is completed such as file location and other properties that might be useful since once this signal is emitted the transfer is gone so there is no way to retrieve this information again. -- Luiz Augusto von Dentz