Return-Path: <cyrus@holtmann.org>
MIME-Version: 1.0
In-Reply-To: <1337865771-11777-6-git-send-email-luiz.dentz@gmail.com>
References: <1337865771-11777-1-git-send-email-luiz.dentz@gmail.com> <1337865771-11777-6-git-send-email-luiz.dentz@gmail.com>
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Date: Thu, 24 May 2012 14:09:19 -0300
Message-ID: <CAMOw1v7+=GefR2K+Wkn89W2ZMR7F_Q52Y_g6+bkeCyXBC07Q2Q@mail.gmail.com>
Subject: Re: [PATCH BlueZ 6/6] audio: Add Volume property to A2DP transport GetProperties
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

On Thu, May 24, 2012 at 10:22 AM, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> Now that volume is being handled by SetProperty it should also be
> available in GetProperties.
> ---
> ?audio/transport.c | ? ?5 +++++
> ?1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/audio/transport.c b/audio/transport.c
> index 6406ec1..4f86a8b 100644
> --- a/audio/transport.c
> +++ b/audio/transport.c
> @@ -860,6 +860,10 @@ static void get_properties_a2dp(struct media_transport *transport,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?DBusMessageIter *dict)
> ?{
> ? ? ? ?dict_append_entry(dict, "Delay", DBUS_TYPE_UINT16, &transport->delay);
> +
> + ? ? ? if (transport->volume <= 127)
> + ? ? ? ? ? ? ? dict_append_entry(dict, "Volume", DBUS_TYPE_UINT16,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? &transport->volume);
> ?}
>
> ?static void get_properties_headset(struct media_transport *transport,
> @@ -1015,6 +1019,7 @@ struct media_transport *media_transport_create(DBusConnection *conn,
> ? ? ? ?transport->size = size;
> ? ? ? ?transport->path = g_strdup_printf("%s/fd%d", device->path, fd++);
> ? ? ? ?transport->fd = -1;
> + ? ? ? transport->volume = -1;

Ack


Lucas De Marchi