Return-Path: MIME-Version: 1.0 In-Reply-To: <20120510124743.339acb16@vader> References: <1336631264-27977-1-git-send-email-joohi.rastogi@stericsson.com> <20120510124743.339acb16@vader> From: Lucas De Marchi Date: Thu, 10 May 2012 12:52:20 -0300 Message-ID: Subject: Re: [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG record To: joohi.rastogi@stericsson.com Cc: User Name Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Thu, May 10, 2012 at 12:47 PM, Lucas De Marchi wrote: > On Thu, 10 May 2012 11:57:44 +0530 > wrote: > >> From: Joohi Rastogi >> >> --- >> ?audio/avrcp.c | ? ?4 +++- >> ?1 files changed, 3 insertions(+), 1 deletions(-) >> >> diff --git a/audio/avrcp.c b/audio/avrcp.c >> index 1b35c3f..7ed1bbb 100644 >> --- a/audio/avrcp.c >> +++ b/audio/avrcp.c >> @@ -93,6 +93,7 @@ >> ?#define AVRCP_FEATURE_CATEGORY_2 ? ? 0x0002 >> ?#define AVRCP_FEATURE_CATEGORY_3 ? ? 0x0004 >> ?#define AVRCP_FEATURE_CATEGORY_4 ? ? 0x0008 >> +#define AVRCP_FEATURE_PLAYER_SETTINGS ? ? ? ?0x0010 >> >> ?enum battery_status { >> ? ? ? BATTERY_STATUS_NORMAL = ? ? ? ? 0, >> @@ -247,7 +248,8 @@ static sdp_record_t *avrcp_tg_record(void) >> ? ? ? uint16_t lp = AVCTP_PSM; >> ? ? ? uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103; >> ? ? ? uint16_t feat = (AVRCP_FEATURE_CATEGORY_1 | >> AVRCP_FEATURE_CATEGORY_2 >> - ? ? ? ? ? ? | AVRCP_FEATURE_CATEGORY_3 | >> AVRCP_FEATURE_CATEGORY_4); >> + ? ? ? ? ? ? | AVRCP_FEATURE_CATEGORY_3 | AVRCP_FEATURE_CATEGORY_4 >> + ? ? ? ? ? ? | AVRCP_FEATURE_PLAYER_SETTINGS); > > Ack, but I'm not sure about the coding style. I think the preferred way > to split lines is to put > > I'm not sure HUmn... sorry, for these incomplete emails. I had some problems with my email client. Lucas De Marchi