Return-Path: <cyrus@holtmann.org>
Date: Thu, 10 May 2012 12:48:28 -0300
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: <joohi.rastogi@stericsson.com>
Cc: User Name <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 2/2] AVRCP: Add missing Player Setting feature in TG
 record
Message-ID: <20120510124828.79c6ffa7@vader>
In-Reply-To: <1336631264-27977-1-git-send-email-joohi.rastogi@stericsson.com>
References: <1336631264-27977-1-git-send-email-joohi.rastogi@stericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

On Thu, 10 May 2012 11:57:44 +0530
<joohi.rastogi@stericsson.com> wrote:

> From: Joohi Rastogi <joohi.rastogi@stericsson.com>
> 
> ---
>  audio/avrcp.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/audio/avrcp.c b/audio/avrcp.c
> index 1b35c3f..7ed1bbb 100644
> --- a/audio/avrcp.c
> +++ b/audio/avrcp.c
> @@ -93,6 +93,7 @@
>  #define AVRCP_FEATURE_CATEGORY_2	0x0002
>  #define AVRCP_FEATURE_CATEGORY_3	0x0004
>  #define AVRCP_FEATURE_CATEGORY_4	0x0008
> +#define AVRCP_FEATURE_PLAYER_SETTINGS	0x0010
>  
>  enum battery_status {
>  	BATTERY_STATUS_NORMAL =		0,
> @@ -247,7 +248,8 @@ static sdp_record_t *avrcp_tg_record(void)
>  	uint16_t lp = AVCTP_PSM;
>  	uint16_t avrcp_ver = 0x0103, avctp_ver = 0x0103;
>  	uint16_t feat = (AVRCP_FEATURE_CATEGORY_1 |
> AVRCP_FEATURE_CATEGORY_2
> -		| AVRCP_FEATURE_CATEGORY_3 |
> AVRCP_FEATURE_CATEGORY_4);
> +		| AVRCP_FEATURE_CATEGORY_3 | AVRCP_FEATURE_CATEGORY_4
> +		| AVRCP_FEATURE_PLAYER_SETTINGS);

Ack, but I'm not sure about the coding style. I think the preferred way
to split lines is to put "|" in the line before (and indent past the
"(".


Lucas De Marchi