Return-Path: MIME-Version: 1.0 In-Reply-To: <20120509090205.GC7628@aemeltch-MOBL1> References: <1336483706-1533-1-git-send-email-dh.herrmann@googlemail.com> <1336483706-1533-3-git-send-email-dh.herrmann@googlemail.com> <1336488880.5970.149.camel@aeonflux> <20120509090205.GC7628@aemeltch-MOBL1> Date: Wed, 9 May 2012 08:17:59 -0300 Message-ID: Subject: Re: [PATCH 3/3] Bluetooth: Remove batostr() From: Ulisses Furquim To: Andrei Emeltchenko , Ulisses Furquim , Marcel Holtmann , David Herrmann , linux-bluetooth@vger.kernel.org, gustavo@padovan.org Content-Type: text/plain; charset=ISO-8859-1 List-ID: Hi Andrei, On Wed, May 9, 2012 at 6:02 AM, Andrei Emeltchenko wrote: > Hi Ulisses, > > On Tue, May 08, 2012 at 03:11:01PM -0300, Ulisses Furquim wrote: >> >> > batostr() is not used anywhere and I don't see any reason why we sh= ould >> >> > keep it. Use ba2str() instead. >> >> > >> >> > Signed-off-by: David Herrmann >> >> > --- >> >> > =A0include/net/bluetooth/bluetooth.h | =A0 =A01 - >> >> > =A0net/bluetooth/lib.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 14 -------= ------- >> >> > =A02 files changed, 15 deletions(-) >> >> >> >> The patchset looks good to me. I'm also not sure we need another >> >> specifier for snprintf(). >> >> >> >> Given we had static buffers instead of allocating them in the stack >> >> every time it'd be good to hear from Marcel if we had a reason and if >> >> it's still valid. IMO we don't have problems with stack usage in our >> >> code paths now but I haven't actually checked it. >> > >> > that code is most likely 11+ years old. It is actually not from me. So >> > if you wanna know why, you need to track down Max. >> > >> > Using %pM and baswap seems to be the best approach for fixing this rig= ht >> > now. However I am not against introducing a snprintf modifier for >> > Bluetooth addresses. >> >> I see. Ok, makes sense. David or Andrei? Will any of you guys send a pat= ch? > > I think that adding print specifier is the best option, we can apply old > patch from Joe Perches. Indeed. I've just seen his e-mail and patch. I just don't understand why we haven't merged it before. Regards, --=20 Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs