Return-Path: Message-ID: <1336499313.4320.4.camel@jlt3.sipsolutions.net> Subject: Re: batostr() function From: Johannes Berg To: Joe Perches Cc: Andrei Emeltchenko , David Herrmann , linux-bluetooth@vger.kernel.org, netdev , "Luis R. Rodriguez" Date: Tue, 08 May 2012 19:48:33 +0200 In-Reply-To: <1336497532.29640.24.camel@joe2Laptop> References: <1336391383.4325.24.camel@jlt3.sipsolutions.net> <1336487108.4320.2.camel@jlt3.sipsolutions.net> <20120508143011.GD29352@aemeltch-MOBL1> <1336497532.29640.24.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2012-05-08 at 10:18 -0700, Joe Perches wrote: > On Tue, 2012-05-08 at 17:30 +0300, Andrei Emeltchenko wrote: > > On Tue, May 08, 2012 at 04:25:08PM +0200, Johannes Berg wrote: > > > On Tue, 2012-05-08 at 15:30 +0200, David Herrmann wrote: > > > > Hi Johannes > > > > > > > > On Mon, May 7, 2012 at 1:49 PM, Johannes Berg wrote: > > > > > Really? 2 static buffers that are used alternately based on a static > > > > > variable? How can that possibly be thread-safe? That may work in very > > > > > restricted scenarios, but ... > > > > > > > > Looking at "git blame" it seems the whole function is still from > > > > linux-2.4. Looks like no-one ever noticed. I've sent a patchset fixing > > > > it, thanks. > > > > > > I was thinking you could use %pM, but it seems BT addresses are stored > > > the wrong way around for some reason ... > > > > This looks like better idea then allocating buffers, we can use swap to > > take care about "wrong order". > > https://lkml.org/lkml/2010/12/3/358 Pretty much what I had in mind, thanks. Luis, you'll notice that this will be a pain to backport in compat. :-) johannes