Return-Path: Date: Tue, 5 Jun 2012 11:15:01 +0800 From: Johan Hedberg To: Gustavo Padovan , Vinicius Costa Gomes , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Fix checking the wrong flag when accepting a socket Message-ID: <20120605031501.GA31521@x220> References: <1338515619-7448-1-git-send-email-vinicius.gomes@openbossa.org> <20120601230052.GF24769@joana> <20120605030151.GA31260@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20120605030151.GA31260@x220> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Tue, Jun 05, 2012, Johan Hedberg wrote: > On Fri, Jun 01, 2012, Gustavo Padovan wrote: > > * Vinicius Costa Gomes [2012-05-31 22:53:39 -0300]: > > > > > Most probably a typo, the check should have been for BT_SK_DEFER_SETUP > > > instead of BT_DEFER_SETUP (which right now only represents a socket > > > option). > > > > > > Signed-off-by: Vinicius Costa Gomes > > > --- > > > net/bluetooth/af_bluetooth.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Patch has been applied to bluetooth-next. thanks. > > This patch fixes accepting L2CAP and RFCOMM connections for sockets with > defer setup enabled (i.e. pretty much *all* sockets we have). This is > now broken in 3.5-rc1 so the patch should go with the highest priority > to the upstream trees. Furthermore, you said you applied it to > bluetooth-next but it's not there. What's going on? Actually the patch is in bluetooth-next (I was checking the wrong tree), sorry about the false alarm there. However the patch really needs to go to bluetooth.git too and then onwards to the upstream trees. Johan