Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1343428380-32705-1-git-send-email-vinicius.gomes@openbossa.org> <1343428380-32705-5-git-send-email-vinicius.gomes@openbossa.org> Date: Fri, 27 Jul 2012 18:55:10 -0400 Message-ID: Subject: Re: [PATCH v3 4/7] Bluetooth: Refactor ACL connection into its own function From: Anderson Lizardo To: Vinicius Costa Gomes Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Vinicius, On Fri, Jul 27, 2012 at 6:52 PM, Anderson Lizardo wrote: > Does it make sense to merge the two if()'s above into one? i.e.: > > if (IS_ERR(acl) || type == ACL_LINK) > return acl; > > It's still clear, IMHO. Nevermind, now I see you just factored out this code on next patch. Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil