Return-Path: <cyrus@holtmann.org>
MIME-Version: 1.0
In-Reply-To: <1343375053-19193-2-git-send-email-jaganath.k@samsung.com>
References: <1343375053-19193-1-git-send-email-jaganath.k@samsung.com> <1343375053-19193-2-git-send-email-jaganath.k@samsung.com>
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Date: Fri, 27 Jul 2012 09:25:53 -0300
Message-ID: <CAMOw1v6wwSLa-goWqZfcEtxMmBXpuQzZit-OgHSDYk+x5cPYTw@mail.gmail.com>
Subject: Re: [PATCH BlueZ] gdbus: Fix compilation error if macro "error" is defined
To: Jaganath Kanakkassery <jaganath.k@samsung.com>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

On Fri, Jul 27, 2012 at 4:44 AM, Jaganath Kanakkassery
<jaganath.k@samsung.com> wrote:
> The variable "signature" used in error is not defined.
> ---
>  gdbus/object.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/gdbus/object.c b/gdbus/object.c
> index 900e7ab..0f05234 100644
> --- a/gdbus/object.c
> +++ b/gdbus/object.c
> @@ -645,8 +645,7 @@ static dbus_bool_t emit_signal_valist(DBusConnection *conn,
>                 goto fail;
>
>         if (g_dbus_args_have_signature(args, signal) == FALSE) {
> -               error("%s.%s: expected signature'%s' but got '%s'",
> -                               interface, name, args, signature);
> +               error("signature does not match");

argh... indeed.

However I'd rather fix it by letting a similar message (without args,
which have a different type):

error("%s.%s: got unexpected signature '%s'",
                               interface, name,
dbus_message_get_signature(signal));


thanks
Lucas De Marchi