Return-Path: MIME-Version: 1.0 In-Reply-To: References: From: Lucas De Marchi Date: Sat, 21 Jul 2012 13:45:59 -0300 Message-ID: Subject: Re: AVRCPv1.3 NOTIFY from CT per notification from TG To: Pavan Savoy Cc: linux-bluetooth@vger.kernel.org, luiz.von.dentz@intel.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Pavan, On Fri, Jul 20, 2012 at 5:39 PM, Pavan Savoy wrote: > Hi, > > Went through the archives, don't see this being discussed. > I read the AVRCPv1.3 spec section mentioned below and to me it looks > like it's been implemented the way it is supposed to be, However, the > question is WHY ? > > /* Unregister event as per AVRCP 1.3 spec, section 5.4.2 */ > player->registered_events ^= 1 << id; > > Does that mean - A car-kit product would keep asking for new > notifications time and again ? That too, It needs to be requesting for > notification for each individual EVENT_ID again and again ? Since 1 > notification request is good for 1 notification & for 1 particular > event ? Yes, TG side can't send an event CT was not registered to. And that means we have to remove the registered event after it has been generated. It's indeed not well designed IMO, but it is what other devices are supposed to implement. Once they receive a notification, if they are still interested in a certain even, they register again to that event. It's racy, but devices out there use it expecting this behavior. > > Wouldn't this make the devices more chatty then they are supposed to > be? Why not enable/disable notifications - And capability to OR > various event IDs ? Not sure I understand what you mean here. Lucas De Marchi