Return-Path: Message-ID: <500520EA.3070804@linux.intel.com> Date: Tue, 17 Jul 2012 10:23:06 +0200 From: Frederic Danis MIME-Version: 1.0 To: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH v12 13/13] audio: Add fast connectable to telephony interface References: <1342090438-20434-1-git-send-email-frederic.danis@linux.intel.com> <1342090438-20434-14-git-send-email-frederic.danis@linux.intel.com> <20120717081021.GB368@x220> In-Reply-To: <20120717081021.GB368@x220> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hello Johan, On 17/07/2012 10:10, Johan Hedberg wrote: > Hi Fr?d?ric, > > On Thu, Jul 12, 2012, Fr?d?ric Danis wrote: >> +# Telephony interface specific options (i.e. options which affect how the >> +# service interacts with remote devices) >> +[Telephony] >> + >> +# Set to true to enable agent to use of fast connectable mode (faster page >> +# scanning) when incoming call starts. Default settings should be restored >> +# after call is answered or rejected. Page scan interval is much shorter and >> +# page scan type changed to interlaced. Such allows faster connection >> +# initiated by a headset. >> +FastConnectable=false > > I don't really see the point of making this configurable and add extra > code complexity because of it. There should be no reason why it couldn't > always be available to the telephony agent. So unless you have a really > good reason for keeping it could you please remove it. > OK, I will remove it Fred -- Frederic Danis Open Source Technology Center frederic.danis@intel.com Intel Corporation