Return-Path: Message-id: <4055A7F7C23040269F1BF78CA05E2844@sisodomain.com> From: Jaganath Kanakkassery To: Lucas De Marchi Cc: linux-bluetooth@vger.kernel.org References: <1343816803-16228-1-git-send-email-jaganath.k@samsung.com> In-reply-to: Subject: Re: [PATCH BlueZ v0] gdbus: Fix compilation error if macro "error" is defined Date: Tue, 14 Aug 2012 19:54:36 +0530 MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=iso-8859-1; reply-type=original Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, -------------------------------------------------- From: "Lucas De Marchi" Sent: Monday, August 13, 2012 7:33 PM To: "Jaganath Kanakkassery" Cc: Subject: Re: [PATCH BlueZ v0] gdbus: Fix compilation error if macro "error" is defined > On Wed, Aug 1, 2012 at 7:26 AM, Jaganath Kanakkassery > wrote: >> The variable "signature" used in error is not defined. >> --- >> v0 -> Made error message as per Lucas's suggestion >> >> gdbus/object.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gdbus/object.c b/gdbus/object.c >> index 900e7ab..9689006 100644 >> --- a/gdbus/object.c >> +++ b/gdbus/object.c >> @@ -645,8 +645,8 @@ static dbus_bool_t emit_signal_valist(DBusConnection >> *conn, >> goto fail; >> >> if (g_dbus_args_have_signature(args, signal) == FALSE) { >> - error("%s.%s: expected signature'%s' but got '%s'", >> - interface, name, args, signature); >> + error("%s.%s: got unexpected signature '%s'", interface, >> name, >> + >> dbus_message_get_signature(signal)); >> ret = FALSE; >> goto fail; > > Ack. > > Lucas De Marchi > -- Ping. Thanks, Jaganath