Return-Path: Date: Tue, 14 Aug 2012 13:28:12 +0300 From: Johan Hedberg To: =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH BlueZ] mgmt: print error message when start_discovery fails Message-ID: <20120814102812.GA8175@x220> References: <1344004954-2762-1-git-send-email-jprvita@openbossa.org> <20120814094010.GB5352@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20120814094010.GB5352@x220> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Tue, Aug 14, 2012, Johan Hedberg wrote: > On Fri, Aug 03, 2012, Jo?o Paulo Rechi Vita wrote: > > If we fail to communicate with the MGMT socket is better to print the > > error message on the mgmtops plugin, where it really happened, instead > > of leaving this job to its users. > > --- > > src/adapter.c | 6 +----- > > src/mgmt.c | 7 +++++-- > > 2 files changed, 6 insertions(+), 7 deletions(-) > > How do these two patches differ from patches 02/14 and 07/14 of the > patch set that was sent on July 27th? Why were these two patches resent > separately? A cover letter would have been quite useful here. Nevermind. I see that they reference the original thread and are probably updates based on received comments. Anyway, it would have been clearer if you'd have added "v2" to the subject and kept the xx/yy numbering. Johan